Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG Manipulation #23

Open
IJustDev opened this issue Aug 26, 2021 · 2 comments
Open

SVG Manipulation #23

IJustDev opened this issue Aug 26, 2021 · 2 comments

Comments

@IJustDev
Copy link

IJustDev commented Aug 26, 2021

Hey everybody and hey @andyruwruw !

Thanks for creating this beautiful library, got it integrated in whatsapp-chess. I would love to add col and row descriptions (ABCDEFGH and 12345678).

We could either achieve this by coding it right into, or by letting the user get the svg itself so he could then manipulate it.

Would love to do this and will open a pr right away!

Hope you will merge it if it suits your roadmap and release it asap.

@IJustDev
Copy link
Author

Okay so just modified my app to handle the rendering of letters itself... If anybody is in need of it:
https://github.com/IJustDev/whatsapp-chess/blob/master/src/commandHandler.ts#L39

I will create a pr containing an option to display them tomorrow

@andyruwruw
Copy link
Owner

Happy you found the lib useful!

I plan on revisiting this and do a bit of refactoring and I'll add those features as well, for now thank you for sharing your implementation :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants