You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Now that custom derives are stable, would this be better done using them instead of a macro_rules macro? That way you can have the FromPrimitive and ToPrimitive trait definitions in enum_primitive and then a enum_primitive_derive crate to do the deriving.
I think something like this is more applicable to macros 1.1 than macros by example, and that way you also fix up long-standing issues like being unable to document each variant.
The text was updated successfully, but these errors were encountered:
@cardoe, can't you just create a pull request? They shouldn't need to give you permissions to the GitHub repo or crates.io package just so you can add a change.
Now that custom derives are stable, would this be better done using them instead of a macro_rules macro? That way you can have the
FromPrimitive
andToPrimitive
trait definitions inenum_primitive
and then aenum_primitive_derive
crate to do the deriving.I think something like this is more applicable to macros 1.1 than macros by example, and that way you also fix up long-standing issues like being unable to document each variant.
The text was updated successfully, but these errors were encountered: