AD4050 support was added by adding appropriate bit resolutions #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Shetty-Anush
commented
Oct 29, 2024
•
Shetty-Anush
commented
- Add appropriate bit resolutions for the devices
- Bug fix - Move if directives to suitable places
- Remove reference of adc drivers present in app folder from .extSettings
- Migrate CubeMX to 6.11.1
SaikiranGudla
previously approved these changes
Oct 30, 2024
jansunil
added
the
peer-reviewed
jansunil
previously approved these changes
Oct 30, 2024
Shetty-Anush
dismissed stale reviews from jansunil and SaikiranGudla
via
1b97b35
Shetty-Anush
force-pushed
the
ad4050__support
branch
from
32cb93a to
1b97b35
Compare
SaikiranGudla
previously approved these changes
Nov 7, 2024
jansunil
requested changes
Nov 7, 2024
| @@ -549,7 +539,7 @@ static int iio_ad405x_attr_get(void *device, | |||
| if (ret) { | |||
| return ret; | |||
| } | |||
| #endif | |||
|
|
|||
There was a problem hiding this comment.
Could we remove this extra line?
|
@Shetty-Anush Astyle checks seem to be failing in the builds. Could you also please look into this? |
Shetty-Anush
force-pushed
the
ad4050__support
branch
2 times, most recently
from
e747d6c to
5e1e029
Compare
1. Add appropriate bit resolutions for the devices 2. Bug fix - Move if directives to suitable places 3. Remove reference of adc drivers present in app folder from .extSettings 4. Migrate CubeMX to 6.11.1 Signed-off-by: Anush Shetty <[email protected]>
Shetty-Anush
force-pushed
the
ad4050__support
branch
from
5e1e029 to
bf06f10
Compare
jansunil
approved these changes
Nov 7, 2024
SaikiranGudla
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.