Migrate python to use pyproject.toml #1202
Open
+115
−211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Installing python through CMake is very error prone and should only be done through pip or similar package manager. User tend to install it with sudo which tends to make the bindings inaccessible. Signed-off-by: Travis F. Collins <[email protected]>
tfcollins
requested review from
cristina-suteu,
dNechita,
mhennerich,
SRaus and
AAndrisa
as code owners
tfcollins
force-pushed
the
tfcollins/pyproject.toml
branch
from
9d81699 to
8ca4a09
Compare
julienmalik
reviewed
Oct 2, 2024
bindings/python/pyproject.toml
Outdated
| [project.urls] | ||
| homepage = "https://analogdevicesinc.github.io/libiio/" | ||
| documentation = "https://analogdevicesinc.github.io/libiio/" | ||
| repository = "https://github/analogdevicesinc/libiio" |
There was a problem hiding this comment.
you must have meant github.com here
Replace old setup.py with project.toml and move single file module to subfolder. setuptools does not support single file modules; therefore, we need to use a subfolder for packaging Signed-off-by: Travis F. Collins <[email protected]>
Make error helpful when python cannot find the libiio C library Signed-off-by: Travis F. Collins <[email protected]>
tfcollins
force-pushed
the
tfcollins/pyproject.toml
branch
from
8ca4a09 to
af0dbae
Compare
nunojsa
approved these changes
Oct 11, 2024
| sudo ldconfig | ||
| cd .. | ||
|
|
||
| - name: Build and test Python bindings |
There was a problem hiding this comment.
nit: The "and test" seems redundant to me given the next step
Signed-off-by: Travis F. Collins <[email protected]>
Signed-off-by: Travis F. Collins <[email protected]>
tfcollins
force-pushed
the
tfcollins/pyproject.toml
branch
from
af0dbae to
bc943a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR addresses #1201 and more improvements. This includes a change away from the CMake install mechanism used for the python bindings which has been historically error prone. Debian for example does not want you to install python packages like we are doing with CMake. Changes include CI updates with testing
PR Type
PR Checklist