Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📦 Update validator devDependencies #39314

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 31, 2023

Mend Renovate

This PR contains the following updates:

Package Update Type Change Package file
com_google_absl digest http_archive c9c0fd5 -> fc44fa0 validator/WORKSPACE
com_google_googletest digest http_archive c875c4e -> 8a6feab validator/WORKSPACE
com_google_javascript_closure_library digest http_archive f94055a -> e896a74 validator/WORKSPACE
com_google_protobuf digest http_archive 4812107 -> f7d6dd1 validator/WORKSPACE
com_googlesource_code_re2 digest http_archive 960c861 -> 87d09ef validator/WORKSPACE
emsdk digest http_archive 3891e7b -> 9b0db91 validator/WORKSPACE
rules_cc digest http_archive 7771fb5 -> b039a55 validator/WORKSPACE
rules_proto digest http_archive 493169c -> 8aa1e67 validator/WORKSPACE

See all other Renovate PRs on the Dependency Dashboard

How to resolve breaking changes

This PR may introduce breaking changes that require manual intervention. In such cases, you will need to check out this branch, fix the cause of the breakage, and commit the fix to ensure a green CI build. To check out and update this PR, follow the steps below:

# Check out the PR branch
git checkout -b renovate/validator-devdependencies main
git pull https://github.com/ampproject/amphtml.git renovate/validator-devdependencies

# Directly make fixes and commit them
amp lint --fix # For lint errors in JS files
amp prettify --fix # For prettier errors in non-JS files
# Edit source code in case of new compiler warnings / errors

# Push the changes to the branch
git push [email protected]:ampproject/amphtml.git renovate/validator-devdependencies:renovate/validator-devdependencies

Configuration

📅 Schedule: Branch creation - "after 12am every weekday" in timezone America/Los_Angeles, Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Never, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the WG: caching label Jul 31, 2023
@renovate renovate bot enabled auto-merge (squash) July 31, 2023 19:21
@amp-owners-bot amp-owners-bot bot requested a review from banaag July 31, 2023 19:21
@amp-owners-bot
Copy link

amp-owners-bot bot commented Jul 31, 2023

Hey @ampproject/wg-caching! These files were changed:

validator/WORKSPACE

@danielrozenberg
Copy link
Member

@banaag PTAL at why amp validator-cpp is breaking. I noticed that with these updates Bazel simply doesn't print INFO: Found 1 test target..., and exists immediately with exit code 1

@renovate renovate bot force-pushed the renovate/validator-devdependencies branch 2 times, most recently from 149b2c2 to 44ee492 Compare August 8, 2023 17:56
@banaag banaag self-requested a review August 22, 2023 18:39
@banaag
Copy link
Contributor

banaag commented Aug 22, 2023

@danielrozenberg @amaltas fixed the validator tests a few weeks ago, not sure if this PR is before or after that but the test are working now. Do we need to update this PR?

@renovate renovate bot force-pushed the renovate/validator-devdependencies branch 2 times, most recently from e42f1f7 to 10fccb5 Compare August 30, 2023 15:04
@danielrozenberg
Copy link
Member

I got renovatebot to rebase this PR, looks like the tests are still failing. @banaag @amaltas PTAL?

@renovate renovate bot force-pushed the renovate/validator-devdependencies branch 2 times, most recently from 0c499ce to 70b08fe Compare September 5, 2023 15:19
@renovate
Copy link
Contributor Author

renovate bot commented Sep 8, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@danielrozenberg danielrozenberg force-pushed the renovate/validator-devdependencies branch from 607ec16 to f7ab543 Compare September 8, 2023 18:40
@danielrozenberg
Copy link
Member

danielrozenberg commented Sep 8, 2023

I bisected the breaking deps and reverted those deps to the last version before the breaking commit.

@renovate renovate bot merged commit ac09579 into main Sep 11, 2023
@renovate renovate bot deleted the renovate/validator-devdependencies branch September 11, 2023 15:28
eszponder pushed a commit to krzysztofequativ/amphtml that referenced this pull request Apr 22, 2024
* 📦 Update validator devDependencies

* Revert `com_google_protobuf` and `emsdk` deps to latest working revision

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel Rozenberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants