Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template sanitizer: respect target #1572

Closed
dvoytenko opened this issue Jan 26, 2016 · 12 comments
Closed

Template sanitizer: respect target #1572

dvoytenko opened this issue Jan 26, 2016 · 12 comments
Assignees
Milestone

Comments

@dvoytenko
Copy link
Contributor

No description provided.

@dvoytenko dvoytenko self-assigned this Jan 26, 2016
@dvoytenko
Copy link
Contributor Author

Blocked by googlearchive/caja#1991

@dvoytenko
Copy link
Contributor Author

Workaround implemented. Still pursuing sanitizer fix.

@dvoytenko
Copy link
Contributor Author

#2834 has been marked as a duplicate of this issue.

@Wadekone
Copy link

Wadekone commented Oct 7, 2016

Per instruction from dvoytenko I would like to clarify if the solution for the issue was developed?
Hope you understand this is an awful UX as every new page user opens is a new browser tab (way too much consumption of mobile device's resource at least). We are currently in a process of implementing the solution that will allow the customers to navigate through AMPs using the AMP CDN and this bug is causing a trouble.
Hope someone can update this thread soon.

Thanks and Best Regards,
Vadim

@dvoytenko
Copy link
Contributor Author

@Wadekone to provide the recap: I'm following up with the sanitizer library to address this issue.

@Wadekone
Copy link

@dvoytenko Appreciated, we are so excited to see the update!

@dvoytenko
Copy link
Contributor Author

@Wadekone Once @5738 is merged, the _top target will be allowed and will also be default.

@Wadekone
Copy link

@dvoytenko Thanks for the heads up!
Side question if I may - is there any information on the amp availability by countries? I know there was a page with websites by countries here like 3 weeks ago, but now it's gone. Also, the last update on this was posted by Elena here back in March. Many of our customers are wondering, perhaps you can put some light on this?
Thanks!

@dvoytenko
Copy link
Contributor Author

I'll refer to @rudygalfi to answer these questions.

@rudygalfi
Copy link
Contributor

I think the page you're referring to was https://www.ampproject.org/learn/who, but it's been changed since. Are you asking specifically about where Google is driving traffic to AMP content (because of course there's nothing about AMP that's country specific).

In terms of countries, I think the article you linked is a majority. I don't have a list, but I think Australia, Canada, Argentina, Colombia have been added since. That's for the Top Stories feature. In terms of regular web results (https://blog.google/products/search/search-results-are-officially-ampd/), it's still rolling out globally.

@Wadekone
Copy link

Wadekone commented Oct 23, 2016

@rudygalfi
Rudy, thanks for your answer! My apologies for being slightly off-topic here.
Basically, we've created AMP magento extension, and our clients are asking us, if AMP results are already being served in their countries. There's no strong knowledge of AMP among ecommerce stores owners yet, since there's only 1 major player in this area right now - the Ebay. But that's one of the main questions they usually ask - do they need this extension if their business is local? I wanted to make sure that I'm telling them precise info, and your answer is what I was looking for - the regular mobile search should be already serving users with AMPd pages. Thank you!

One other question while we're talking - Top Results section. Should we expect that the pages with type "article" will be included there, regardless if that's the news page, or store page? Appreciate your reply!

By the way, the WHO page should also include Magento in the CMS section, since there are already 3 companies selling AMP extension for Magento ;)

Thanks again for your time and for your useful responses!

Best Regards,

@rudygalfi
Copy link
Contributor

With the Top Stories question, we're getting into Google Search behavior here, and this isn't really the right place for those questions, but this is.

https://developers.google.com/search/docs/data-types/articles says: "Top Stories with AMP is a Google Search results feature that displays articles and video pages from sites" but the requirements are "the following schema.org types: Article, NewsArticle, BlogPosting, or VideoObject."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants