Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPStan 2.x is available #7917

Open
westonruter opened this issue Nov 12, 2024 · 1 comment
Open

PHPStan 2.x is available #7917

westonruter opened this issue Nov 12, 2024 · 1 comment
Labels
Enhancement New feature or improvement of an existing one

Comments

@westonruter
Copy link
Member

Feature Description

PHPStan 2.x is currently available. However, it is blocked by the built-in AMP plugin extensions to PHPStan:

services:
-
class: AmpProject\AmpWP\Tests\PhpStan\ServiceContainerDynamicReturnTypeExtension
tags:
- phpstan.broker.dynamicMethodReturnTypeExtension
-
class: AmpProject\AmpWP\Tests\PhpStan\ServicesDynamicReturnTypeExtension
tags:
- phpstan.broker.dynamicStaticMethodReturnTypeExtension

As well as to this unrecognized config:

amp-wp/phpstan.neon.dist

Lines 38 to 39 in e9b7e61

featureToggles:
requireFileExists: false

We'll need to follow the upgrading instructions in particular to address the former.

Acceptance Criteria

No response

Implementation Brief

No response

QA Testing Instructions

No response

Demo

No response

Changelog Entry

No response

@westonruter westonruter added the Enhancement New feature or improvement of an existing one label Nov 12, 2024
@westonruter
Copy link
Member Author

For now we are pinned at 1.x: #7916

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or improvement of an existing one
Projects
None yet
Development

No branches or pull requests

1 participant