-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.9.0 - What can we add/change or enhance? #213
Comments
Is there currently a way to retrieve all key/value pairs like in AsyncStorage, which was used to migrate to MMKV? That may be helpful. |
@robkainz Just use |
Mocks for Jest please 🙏 |
@ahmedu007 in progress |
@ahmedu007 jest mocks shipped in v0.7.0 |
For first thanks for your work. ❤️❤️ |
@dancixx Did you run |
@ammarahm-ed yes I run it, but got the same error, but I think the error is on my side, so I will drop the expo in the near future. Maybe I give it one more chance for it this weekend I write the result. |
Hi, I have a strange error when I try to store a map as a value in MMKV storage. After saving a map and reopening the app, the map is empty, but the strings I stored in other keys are there. Is this a known issue? |
Convert map to simple object before saving in storage. |
Thank you, that works. |
Will there be support for react-native-windows? |
Hi, Would be nice to have support for groupId when initializing mmkv. Recently got it to work with the help I got from @ammarahm-ed , but I still need to test encrypted store. Also how would you support web? by replacing with local storage? |
@humaidk2 For web, we will use groupId can be supported but only through adding a value to |
Wow I didn't know about local-forage, I don't mean to ask too many questions here but what if the data can't be stored on web. Since web is really limited compared to mmkv. Technically, the developer could create a smaller web mmkv instance and migrate data through that. info.plist sounds like a cool plan, considering the bundle id is already there, it would be easier to differentiate between build flavors too. Also I'm guessing for e2e, you're looking to use detox? I do recommend it, it seems the build problems are gone and it's working well with latest react native. |
@humaidk2 local-forage is quite close to mmkv in architecture with support for multiple instances etc. The only difference is that mmkv is fully sync while local-forage is async storage. Hence the limitation of web to only use async methods while use localStorage for the sync API with a warning. There's already a branch were I am working on the implementation. And yes, detox would be it. |
🙏🙏 Please add an equalityFn like useSelector of react-redux in useMMKVStorage hook. |
@djintalkalan will add this. |
Hi @ammarahm-ed, I published Flipper plugin for this library, you can add it to somewhere in your document website. |
@pnthach95 That's great! I will update the docs once in release v0.8.0 this Sunday. |
would love it if we can add ttl type of expiration to the keys. |
@crypt0miester What is the use-case for it |
caching would be a good use case. |
Those 2 things would be so dope ! Using react-native-mmkv-storage for react-redux and it can be very huge amount of data sometimes Edit just saw we already have it, perfect 😄 |
You can try async get/set for items in bulk in the latest alpha, v0.10.0 |
You can try async get/set for items in bulk in the latest alpha, v0.10.0. Haven't added multiGet/multiSet polyfills yet but we have setMultipleItemsAsync/getMultipleItemsAsync which do most of the work off the js thread by default. |
Yeah saw about the setMultipleItemsAsync/getMultipleItemsAsync. Thank you very much, this is a very good library 👍 |
Thanks @ammarahm-ed for the great work on this package. I have a couple of questions:
Cheers. |
I've noticed that the Async methods currently serve as wrappers over regular methods.
@ammarahm-ed , in the evolution of this package, is there a plan to integrate native async calls into these wrappers in future updates? Also, I'd like to ask if this package could be used to store binary data compactly (without serializing to strings)? |
thanks for great library, please consider adding web support |
New Architecture is set by default in next version https://github.com/facebook/react-native/pull/43135/files It's time to add New Architecture support |
Did you ever continue on adding support for web? |
same question |
Is there any ways to get slices from array? Currently
Maybe we can set start index, and end index.
|
I have some ideas on how we can make the library even better.
v0.7.0 (Released)
v0.9.0
Anything else.. drop a comment below and we can discuss
The text was updated successfully, but these errors were encountered: