-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: install runtimes for packages installed by vcpkg #279
base: main
Are you sure you want to change the base?
feat: install runtimes for packages installed by vcpkg #279
Conversation
~~Although this works well on my MacBook, it clearly needs to be tested with CI. However, I'm not sure how to write tests for it. Could you provide some suggestions? @aminya ~~ I choose to simply run the installed executable after installation. |
b4dbce0
to
757ec8d
Compare
The tests should be good. We can also test it in a Docker container to make sure it runs in a clean system. |
15fe2fb
to
6584b44
Compare
00e144d
to
0291688
Compare
The vcpkg part is done. Blocked by conan because it only supports runtime installation when it is invoked separately, as opposed to including conan_provider.cmake in CMakeLists.txt. conan-io/conan#17018 |
According to the maintainer, conan might add the support in 2.9 (currently 2.7.1). Let's merge the vcpkg part first and merge the conan part once it gets supported. |
0291688
to
9ccd37f
Compare
@aminya I'm not familiar enough with Docker and the test framework of this project, so I'm not able to write such a docker test. Could you finish this part of test? The rest is ready to merge btw. |
resolves #261resolves the vcpkg part of #261