Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update setuptools files introducing setup.cfg #6

Merged
merged 5 commits into from
Oct 5, 2021
Merged

Update setuptools files introducing setup.cfg #6

merged 5 commits into from
Oct 5, 2021

Conversation

diegoferigo
Copy link
Member

Beyond updating the resources, this PR also fixes #5. Needs a new release of gym-ignition.

@diegoferigo diegoferigo self-assigned this Jul 2, 2021
@diegoferigo
Copy link
Member Author

In CI, without manually specifying the IGN_GAZEBO_PHYSICS_ENGINE_PATH environment variable, the physics plugin cannot be found. I temporarily exported it and it seems working, though robotology-legacy/gym-ignition#369 could provide a permanent fix.

@diegoferigo diegoferigo force-pushed the feature/setup.cfg branch 2 times, most recently from 4debd64 to b9dbce0 Compare July 27, 2021 09:25
@diegoferigo
Copy link
Member Author

This PR is now ready to be merged. Blocked only by a new gym-ignition / ScenarIO release that supports Edifice.

@diegoferigo
Copy link
Member Author

diegoferigo commented Oct 3, 2021 •
edited
Loading

TODO:

  • Update to Fortress since the next gym-ignition 1.3 will be based on this distribution
  • Add logic to require a compatible gym-ignition / scenario version from PyPI (e.g. scenario ~= 1.3.0.dev) but allowing to build against any distribution from git (optionally with minimum requirements if there are any). This makes the deployed wheels ABI compatible with gym-ignition / scenario. We have to tackle this as soon as we start distributing wheels, currently only sdist are distributed.

@diegoferigo diegoferigo force-pushed the feature/setup.cfg branch 2 times, most recently from 13efbc2 to 4cfce87 Compare October 5, 2021 09:53
@diegoferigo diegoferigo marked this pull request as ready for review October 5, 2021 10:06
@diegoferigo diegoferigo merged commit 8cbd4d8 into master Oct 5, 2021
@diegoferigo diegoferigo deleted the feature/setup.cfg branch October 5, 2021 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@diegoferigo diegoferigo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Depend on scenario instead of gym-ignition
1 participant
@diegoferigo