Skip to content
This repository has been archived by the owner on Oct 25, 2021. It is now read-only.

Debug menu #16

Open
khskarl opened this issue Apr 23, 2019 · 4 comments
Open

Debug menu #16

khskarl opened this issue Apr 23, 2019 · 4 comments
Labels
development friction Label for problems and solutions related to friction felt by developers. good first issue Good for newcomers help wanted Extra attention is needed

Comments

@khskarl
Copy link
Member

khskarl commented Apr 23, 2019

Currently debugging is really not the smoothest experience, the only way to watch values for variables is by inserting prints everywhere and changing them on-the-fly is an even bumpier road.

I propose using this really cool project: https://github.com/Awpteamoose/amethyst-inspector
image

Seems like a solution to this problem and is simple enough to integrate.

Also, feel free to write on this issue any development frictions that could be improved by better debugging support on the Amethyst side, e.g. more helpful error messages, more debug drawing options besides debug lines.

@khskarl khskarl added the development friction Label for problems and solutions related to friction felt by developers. label Apr 23, 2019
@erlend-sh
Copy link
Member

I assume we’d only use this for local play testing? Making imgui work for WASM deployment is out of scope for some time still, possibly always.

@khskarl
Copy link
Member Author

khskarl commented Apr 23, 2019

Yes, it's really easy to gate this out when building for wasm.

We can gate out imgui code like this:

#[cfg(not(target_arch = "wasm32"))]
fn inspect(&mut self, entity: Entity, ui: &imgui::Ui<'_>) {
    ...imgui usage...
}

But I'm not sure if that's enough or we need to explicitly state somewhere that amethyst-inspector isn't a dependency when targeting wasm.

@khskarl
Copy link
Member Author

khskarl commented Apr 27, 2019

Closing the issue as the inspector has been merged in #17 :).

@khskarl khskarl closed this as completed Apr 27, 2019
@erlend-sh
Copy link
Member

As this was temporarily disabled in #79 pending an update, I’m reopening this as a starter-friendly task.

@erlend-sh erlend-sh reopened this Jul 26, 2019
@erlend-sh erlend-sh added good first issue Good for newcomers help wanted Extra attention is needed labels Jul 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
development friction Label for problems and solutions related to friction felt by developers. good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants