Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Remove Topic from api syncer stores #581

Open
keyserj opened this issue Dec 1, 2024 · 0 comments
Open

[refactor] Remove Topic from api syncer stores #581

keyserj opened this issue Dec 1, 2024 · 0 comments
Labels
refactor reduces tech debt or improves code quality
Milestone

Comments

@keyserj
Copy link
Collaborator

keyserj commented Dec 1, 2024

Since addressing #556 , the only reason for storing Topic in the api syncer stores is so that we know which Topic to make the changes to when creating the API request.

Storing the Topic is annoying because we have to ensure it's always correct, matching our current route. There are no plans to edit Topics from pages that aren't the Topic's page, so it doesn't seem worth doing this - we should be able to instead get the Topic from the current URL when creating the API request. If we want to edit Topics from a different page than their own page, we can figure that out later.

@keyserj keyserj added the refactor reduces tech debt or improves code quality label Dec 1, 2024
@keyserj keyserj added this to the update #6 milestone Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor reduces tech debt or improves code quality
Projects
Status: No status
Development

No branches or pull requests

1 participant