Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[autoGuides] End date and start date are computed wrong for each guide #6

Open
bogdanalexe90 opened this issue Apr 8, 2016 · 1 comment

Comments

@bogdanalexe90
Copy link

The weekend guides are not computed correctly. The problem seems to appear from this pice of code:

      // calculate beginning and end of day
      var start = new Date( date );
      start.setHours( 0, 0, 0 );
      var end = new Date( date );
      start.setHours( 23, 59, 59 );

it should be like:

      // calculate beginning and end of day
      var start = new Date( date );
      start.setHours( 0, 0, 0 );
      var end = new Date( date );
      end.setHours( 23, 59, 59 );
xorspark added a commit to xorspark/tools that referenced this issue Apr 21, 2016
- Fix issue where autoGuide plugin created a "banded"/gradient
  effect when chart data's minPeriod < DD
- Fix jshint warning with loader.complete assignment
- Fix guide star/end date calculation from issue amcharts#6
@Pauan
Copy link
Collaborator

Pauan commented Sep 30, 2016

Hi @bogdanalexe90, sorry for not getting back to you sooner on this.

On April 21st we made some changes to the autoGuides plugin.

After upgrading to the latest version, do you still have this problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants