Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove need for __construct in EncryptorInterface #4

Open
slootjes opened this issue Feb 11, 2016 · 1 comment
Open

Remove need for __construct in EncryptorInterface #4

slootjes opened this issue Feb 11, 2016 · 1 comment
Assignees

Comments

@slootjes
Copy link

The __construct in the interface now takes away the freedom to implement your own encryptor which does more than just using a key. I want to create a asymmetrical encryptable class where I need to pass services to the __construct. It would be better if the encryptor was set as a service and then passed as a whole instead of initializing the encryptor and passing the key in the service.

@ambta
Copy link
Owner

ambta commented Feb 12, 2016

Hi Slootjes,

This will be included in the next version.
Thanks for your feedback!

jayesbe referenced this issue in Indinuity/DoctrineEncryptBundle May 11, 2018
Fixing the commands and the Subscriber
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants