Breaking change: reconnect_to_initial_nodes will be called only when AllConnectionsUnavailable #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n map but to extend it
barshaul
force-pushed
the
fix_reconnect_from_init
branch
from
da6e639
to
07ad7dd
Compare
…Unavailable, added new error ConnectionNotFoundForRoute
barshaul
force-pushed
the
fix_reconnect_from_init
branch
from
07ad7dd
to
6e4a94f
Compare
barshaul
changed the title
barshaul
changed the title
barshaul
force-pushed
the
fix_reconnect_from_init
branch
from
5525ad0
to
7e8c31c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes: The
ClusterConnectionNotFounderror has been renamed toAllConnectionsUnavailable, and a new error,ConnectionNotFoundForRoute, has been introduced to handle cases where a specific connection cannot be found. Previously,ClusterConnectionNotFoundwas incorrectly used for missing specific connections, which triggeredreconnect_to_initial_nodes. However,reconnect_to_initial_nodesshould only be invoked when all connections are unavailable, as its purpose is to gather more information from the seed nodes. With this update, whenConnectionNotFoundForRouteis encountered, the system will callrefresh_slotsand retry the request according to the configured retry logic.Although
reconnect_to_initial_nodesis now intended to be called only when no available connections are found, there might still be scenarios where it is triggered even though the connection map isn't empty, due to ongoing tasks refreshing connections. Currently, whenreconnect_to_initial_nodesis called, we create a connection map that includes only the seed nodes provided by the user, replacing the existing connection map. This approach introduces a period where the connection map contains only a subset of the cluster nodes (e.g., the seed nodes), and the slots haven't been refreshed yet. During this time, new requests may come in and find connections only to the seed nodes. If the seed nodes are no longer valid, the client will be unable to send requests to random nodes or rely on MOVED responses. This PR updates the function to extend the connection map with connections retrieved from the seed nodes, rather than replacing it entirely.Reduced number of retries on tests to speed them up