add region override function for region failover #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiajon
requested review from
chauhuynh97 and
haomingli2020
and removed request for
a team
mhiaror
reviewed
Jun 20, 2024
| logMetaData.region = region; | ||
| if (this.clientCache[region]) { | ||
| return this.clientCache[region]; | ||
| } | ||
| var client = this._createAwsClient(options, logMetaData); | ||
| let client = this._createAwsClient(region, logMetaData); |
There was a problem hiding this comment.
QQ. by changing from options to region , we are backwards incompatible here . optionsInput is lost ?
There was a problem hiding this comment.
Seems like its not exposed to the customer so the change is safe .
There was a problem hiding this comment.
no other fields in optionsInput was used previous to this change
mhiaror
approved these changes
Jun 20, 2024
haomingli2020
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adding region override function to enable region fail over in CCP