Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LMR+PVS #229

Open
ChizhovVadim opened this issue May 9, 2022 · 1 comment
Open

LMR+PVS #229

ChizhovVadim opened this issue May 9, 2022 · 1 comment

Comments

@ChizhovVadim
Copy link

I think, if LMR>0, research should be if score > alpha without score < beta. Or I do not understand how it works :-).

score := -e.alphaBeta(depthLeft-1-LMR, searchHeight+1, -alpha-1, -alpha)
if score > alpha && (LMR>0||score < beta) {
...
}

zahak/search/search.go

Lines 745 to 751 in 72ff806

score := -e.alphaBeta(depthLeft-1-LMR, searchHeight+1, -alpha-1, -alpha)
e.pred.Pop()
if score > alpha && score < beta {
// research with window [alpha;beta]
e.pred.Push(position.Hash())
e.innerLines[searchHeight+1].Recycle()
score = -e.alphaBeta(depthLeft-1, searchHeight+1, -beta, -alpha)

@amanjpro
Copy link
Owner

Yeah, I doubt the beta will change anything really... it might hurt too. Will check it :)
Thanks for the report :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants