Skip to content
This repository has been archived by the owner on Apr 13, 2024. It is now read-only.

[Bug] Generated vue sources do not match with what is shown in the editor #28

Closed
rustemgareev opened this issue May 9, 2018 · 2 comments
Labels
🐞 bug Something isn't working

Comments

@rustemgareev
Copy link

Currently, top app bar can be moved to the any Y point of the page. Ideally, it should stay on top of the page, whether it "fixed-to-top" or not.

@alxpez
Copy link
Owner

alxpez commented May 9, 2018

Thanks @rustemgareev,

You're right, in fact if:

  1. You place the TopAppBar anywhere in the editor
  2. Generate vuejs sources
  3. Then run your generated vue project
  4. The TopAppBar is fixed to the top of the page (as it should)

So I see your point, now my question is if this fits under a Feature or a Bug.

Definitely it makes sense to limit the location of the TopAppBar, which I'll be implementing (I take that as a feature), but the current behaviour is buggy, since the generated project should match what is seen on the editor.

Thanks for reporting!

@alxpez alxpez added 🐞 bug Something isn't working feature New feature or request and removed feature New feature or request labels May 9, 2018
@alxpez alxpez changed the title [Feat] Top app bar should stay on top of the page [Bug] Generated vue sources do not match with what is shown in the editor May 12, 2018
@alxpez
Copy link
Owner

alxpez commented May 12, 2018

I'll be leaving this issue for the bug on the sources generation, since #30 contains a reference to the feature related to fixing certain elements

@alxpez alxpez mentioned this issue May 12, 2018
9 tasks
@alxpez alxpez closed this as completed May 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants