From 2be5e1a1565271b1888cc6104e7e376fcc1e6cd4 Mon Sep 17 00:00:00 2001 From: Ana Botto Date: Wed, 26 Jun 2024 15:57:25 +0100 Subject: [PATCH] Add error items to flag the form elements on error --- app/helpers/errors_helper.rb | 6 +++--- app/views/homepage/popular_links/_form.html.erb | 2 ++ 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/app/helpers/errors_helper.rb b/app/helpers/errors_helper.rb index 72882f569..7bc1fddb8 100644 --- a/app/helpers/errors_helper.rb +++ b/app/helpers/errors_helper.rb @@ -1,14 +1,14 @@ module ErrorsHelper - def errors_for(errors, attribute) + def errors_for(errors, attribute, use_full_message: true) return nil if errors.blank? errors.filter_map { |error| if error.attribute == attribute { - text: error.full_message, + text: use_full_message ? error.full_message : error.message, } end } - .presence + .presence end end diff --git a/app/views/homepage/popular_links/_form.html.erb b/app/views/homepage/popular_links/_form.html.erb index 810dc53e0..744bbb369 100644 --- a/app/views/homepage/popular_links/_form.html.erb +++ b/app/views/homepage/popular_links/_form.html.erb @@ -10,6 +10,7 @@ name: "popular_links[#{index + 1}][title]", id: "title#{index + 1}", value: item[:title], + error_items: errors_for(form.object.errors, "title#{index + 1}".to_sym, use_full_message: false), } %> <%= render "govuk_publishing_components/components/input", { @@ -19,4 +20,5 @@ name: "popular_links[#{index + 1}][url]", id: "url#{index + 1}", value: item[:url], + error_items: errors_for(form.object.errors, "url#{index + 1}".to_sym, use_full_message: false), } %>