Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP #255

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

WIP #255

wants to merge 3 commits into from

Conversation

robinjam
Copy link

What problem does the pull request solve?

Checklist

  • I’ve used the pull request template
  • I’ve written unit tests for these changes
  • I’ve updated the documentation in
  • I’ve bumped the version number
    • in src/main/resources/application.properties
    • in pom.xml

In the new deploy pipeline, the AWS cli will be used to fetch the SSM
parameter containing the environment variables required to run the
integration tests.

We also copy the repo into the built image so that we don't need to
_also_ back the repo into the deployment bag.
We shouldn't be using the `integration-test` goal directly because:

* It doesn't check the results of the tests, meaning the build succeeds
  even if the tests fail
* The post-integration-test phase, which tears down the test
  environment, doesn't run

https://maven.apache.org/surefire/maven-failsafe-plugin/index.html
@robinjam robinjam force-pushed the jar-use-ft-fixtures-2 branch from 9cdcd8e to 38496f6 Compare December 12, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant