[WIP] Use functional test fixtures #254
Draft
+58
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the new deploy pipeline, the AWS cli will be used to fetch the SSM parameter containing the environment variables required to run the integration tests. We also copy the repo into the built image so that we don't need to _also_ back the repo into the deployment bag.
We shouldn't be using the `integration-test` goal directly because: * It doesn't check the results of the tests, meaning the build succeeds even if the tests fail * The post-integration-test phase, which tears down the test environment, doesn't run https://maven.apache.org/surefire/maven-failsafe-plugin/index.html
robinjam
force-pushed
the
jar-use-ft-fixtures
branch
from
67ea358 to
83430f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card