Skip to content

Commit

Permalink
Makefile: Use Maven verify goal instead of integration-test
Browse files Browse the repository at this point in the history
We shouldn't be using the `integration-test` goal directly because:

* It doesn't check the results of the tests, meaning the build succeeds
  even if the tests fail
* The post-integration-test phase, which tears down the test
  environment, doesn't run

https://maven.apache.org/surefire/maven-failsafe-plugin/index.html
  • Loading branch information
robinjam committed Nov 26, 2024
1 parent 907624c commit 9cdcd8e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ test: ## Run tests

.PHONY: integration-test
integration-test: ## Run integration tests
mvn --batch-mode clean integration-test
mvn --batch-mode clean verify -Dgpg.skip

.PHONY: bootstrap-with-docker
bootstrap-with-docker: ## Prepare the Docker builder image
Expand Down

0 comments on commit 9cdcd8e

Please sign in to comment.