diff --git a/app/controllers/content_items_controller.rb b/app/controllers/content_items_controller.rb index 53b26cd89..4c92781db 100644 --- a/app/controllers/content_items_controller.rb +++ b/app/controllers/content_items_controller.rb @@ -152,9 +152,7 @@ def load_content_item def ordered_related_items(links) return [] if links["ordered_related_items_overrides"].present? - links["ordered_related_items"].presence || links.fetch( - "suggested_ordered_related_items", [] - ) + links["ordered_related_items"] end def format_banner_links(links, type) diff --git a/test/controllers/content_items_controller_test.rb b/test/controllers/content_items_controller_test.rb index 5e4c880c5..98f95de0b 100644 --- a/test/controllers/content_items_controller_test.rb +++ b/test/controllers/content_items_controller_test.rb @@ -153,16 +153,6 @@ class ContentItemsControllerTest < ActionController::TestCase assert_nil content_item["links"]["ordered_related_items"] end - test "gets item from content store and replaces ordered_related_items there are no existing links or overrides" do - content_item = content_store_has_schema_example("case_study", "case_study") - - get :show, params: { path: path_for(content_item) } - assert_response :success - assert_empty content_item["links"]["ordered_related_items"], "Content item should not have existing related links" - assert_not_empty content_item["links"]["suggested_ordered_related_items"], "Content item should have existing suggested related links" - assert_equal assigns[:content_item].content_item["links"]["ordered_related_items"], content_item["links"]["suggested_ordered_related_items"] - end - test "sets the expiry as sent by content-store" do content_item = content_store_has_schema_example("case_study", "case_study") stub_content_store_has_item(content_item["base_path"], content_item, max_age: 20)