Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Implement From<TypedTransaction> for OpTypedTransaction #34

Closed
refcell opened this issue Aug 23, 2024 · 2 comments
Closed

[Feature] Implement From<TypedTransaction> for OpTypedTransaction #34

refcell opened this issue Aug 23, 2024 · 2 comments

Comments

@refcell
Copy link
Collaborator

refcell commented Aug 23, 2024

Component

consensus, eips, genesis

Describe the feature you would like

Implement a From<TypedTransaction> for OpTypedTransaction where TypedTransaction is from anvil.
Place this behind an anvil feature flag so that the by-default this impl doesn't add dependency bloat.

Additional context

This is used for reading anvil transactions into rust test fixtures as in op-test-vectors.
@mattsse
Copy link
Member

mattsse commented Aug 24, 2024

ref foundry-rs/foundry#8595

@mahmudsudo
Copy link

Hi , can i take on this issue ?

@refcell refcell closed this as completed Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mattsse @refcell @mahmudsudo