Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: simplify events for did documents #329

Merged
merged 2 commits into from
Jan 24, 2022
Merged

feat: simplify events for did documents #329

merged 2 commits into from
Jan 24, 2022

Conversation

noandrea
Copy link
Contributor

@noandrea noandrea commented Jan 20, 2022 •
edited
Loading

also update to protobuf event model.

It is breaking since it removes existing event types

@noandrea
feat: simplify events for the did document
f2aa10d 
also update to protobuf event model
@noandrea noandrea added BREAKING Identify a PR with breaking changes cascading A PR that is targeting another branch that is not main labels Jan 20, 2022
@noandrea noandrea requested a review from PaddyMc January 20, 2022 23:34
@noandrea noandrea linked an issue Jan 21, 2022 that may be closed by this pull request
Define and document the events supported by the module #325
Open
PaddyMc
PaddyMc approved these changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@PaddyMc PaddyMc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧙‍♂️

@noandrea noandrea merged commit 3f29ddf into feat/gh323-update Jan 24, 2022
@noandrea noandrea deleted the feat/325-did-events branch January 24, 2022 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaddyMc PaddyMc PaddyMc approved these changes

Assignees
No one assigned
Labels
BREAKING Identify a PR with breaking changes cascading A PR that is targeting another branch that is not main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Define and document the events supported by the module
2 participants
@noandrea @PaddyMc