From ff8c063597222e1f4a9aa71e9fa66769ebedf4be Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Candice=20Bent=C3=A9jac?= Date: Fri, 4 Oct 2024 18:56:34 +0200 Subject: [PATCH] [core] Node: Do not automatically upgrade unknown nodes in templates --- meshroom/core/node.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/meshroom/core/node.py b/meshroom/core/node.py index 2c9466b879..b78f3725e6 100644 --- a/meshroom/core/node.py +++ b/meshroom/core/node.py @@ -1922,7 +1922,9 @@ def nodeFactory(nodeDict, name=None, template=False, uidConflict=False): if not internalFolder and nodeDesc: logging.warning("No serialized output data: performing automatic upgrade on '{}'".format(name)) node = node.upgrade() - elif template: # If the node comes from a template file and there is a conflict, it should be upgraded anyway + # If the node comes from a template file and there is a conflict, it should be upgraded anyway unless it is + # an "unknown node type" conflict (in which case the upgrade would fail) + elif template and compatibilityIssue is not CompatibilityIssue.UnknownNodeType: node = node.upgrade() return node