Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Optimize] Optimizing autoconfiguration properties in seata #3756

Open
yuluo-yx opened this issue Jun 6, 2024 · 5 comments
Open

[Optimize] Optimizing autoconfiguration properties in seata #3756

yuluo-yx opened this issue Jun 6, 2024 · 5 comments

Comments

@yuluo-yx
Copy link
Collaborator

yuluo-yx commented Jun 6, 2024

lQLPJyEW4dOLql3NAz3NBBWwkUdzf-PIcfQGMwDXk0eSAA_1045_829

As shown in the figure, this part of the configuration is relatively redundant compared to the integration of spring cloud alibaba, we can remove these configuration items by setting the default properties to simplify the yml configuration.

@uytrytryi7y7665688
Copy link

seata.config.type and seata.registry.type was put in a hashMap ,this hashmap was instance a DefaultValueFromPropertyObject

@yuluo-yx
Copy link
Collaborator Author

yuluo-yx commented Aug 3, 2024

image
@uytrytryi7y7665688 img upload failed.

@yuluo-yx
Copy link
Collaborator Author

yuluo-yx commented Aug 3, 2024

seata.config.type and seata.registry.type was put in a hashMap ,this hashmap was instance a DefaultValueFromPropertyObject

yep, so what your means?

@uytrytryi7y7665688
Copy link

If there is no system property, springboot environment, And arguments, resput are assigned and returned by the DefaultValueFromPeopleObject, which is then loaded by the EnhancedService Loader in the ConfigurationFactory and assigned to the CURRENT_Sile-INSTANCE field. Can we change its initial value from file to nacos during class loading initialization???

@yuluo-yx
Copy link
Collaborator Author

yuluo-yx commented Aug 3, 2024

I don't understand what you're trying to say, the requirement of this issue is just to give the seata attribute a default value, it doesn't seem that complicated, you can see how it's implemented in other starters, and it doesn't have anything to do with nacos, it's just that the value of seata is changed to nacos in this case, and nacos is used as a registry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants