Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interactive): Align Data Type in GIE Physical Pb with Flex #4367

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

shirly121
Copy link
Collaborator

@shirly121 shirly121 commented Dec 16, 2024

What do these changes do?

  1. support flex type system in GIE physical proto.
  2. support type conversion among different type systems, we have 3 type systems currently:
    a. Groot: defined in proto
    b. Flex: defined in proto
    c. Calcite, defined in java

The Calcite type system serves as the foundation for type inference in the compiler. Consequently, any other type system (e.g., Groot or Flex) must be convertible to Calcite.

The IrDataTypeConvertor plays a key role in this process. It defines the bidirectional type conversions between Calcite and the other two type systems.

Related issue number

Fixes #4362

@shirly121 shirly121 changed the title Ir align type fix(interactive): Align Data Type in GIE Physical Pb with Flex Dec 16, 2024
Copy link
Contributor

github-actions bot commented Dec 16, 2024

Please check the preview of the documentation changes at
https://b7678549.graphscope-docs-preview.pages.dev

Committed-by: xiaolei.zl from Dev container
@shirly121 shirly121 marked this pull request as ready for review December 30, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(interactive): Align DataType in Physical Pb with Flex
3 participants