Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make algorand client persistent for test fixture #356

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joe-p
Copy link
Contributor

@joe-p joe-p commented Dec 13, 2024

Proposed Changes

  • Restores algorand client to be persistent for a given fixture as it was in ad7dc8e

@joe-p
Copy link
Contributor Author

joe-p commented Dec 13, 2024

This is seemingly breaking tests inconsistently but not entirely sure why. I can investigate further but if anyone has some insight that would be appreciated. @robdmoore do you know why this was changed in the first place?

@neilcampbell
Copy link
Contributor

neilcampbell commented Dec 14, 2024

@joe-p Yeah that's why it was changed.
From memory it was due to parallel test execution resulting in a non thread safe like behaviour (obviously no threads in JS) on the AlgorandClient.

Because AlgorandClient is stateful, it's possible for a test to change the AlgorandClient internal state, whilst another test is also being executing. I'm assuming it's whilst an async function is being awaited or something like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants