Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: patching algopy import syntax in hello world #30

Merged
merged 3 commits into from
Jun 27, 2024

Conversation

aorumbayev
Copy link
Collaborator

Proposed Changes

  • Fix algopy import syntax

@aorumbayev aorumbayev merged commit 3880851 into main Jun 27, 2024
1 check passed
@aorumbayev aorumbayev deleted the fix/patch-algopy-import-syntax branch June 27, 2024 15:46
@achidlow
Copy link
Contributor

achidlow commented Jun 28, 2024

This an okay change to make, but it's not just a syntax change between using algopy.arc4.String and algopy.String, it will change the byte code (probably for the better).

I'd keep the from algopy import arc4 though, rather than from algopy.arc4 import xyz, this is especially helpful to see at a glance where ARC-4 types are being used vs native, especially in the case the classes have the same names like String and UInt64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants