Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: provider models for signing transactions #13

Merged
merged 1 commit into from
Aug 27, 2024
Merged

feat: provider models for signing transactions #13

merged 1 commit into from
Aug 27, 2024

Conversation

PhearZero
Copy link
Member

Overview

  • adds ARC27 Provider messages
  • fixes tsconfig build issues
  • exports Provider as subpackage @algorandfoundation/algo-models/provider

Issues

@PhearZero PhearZero added the enhancement New feature or request label Aug 26, 2024
@PhearZero PhearZero self-assigned this Aug 26, 2024
@PhearZero PhearZero requested a review from ehanoc August 26, 2024 19:55
ehanoc
ehanoc requested changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@ehanoc ehanoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just a couple comments

examples/esm/index.js Show resolved Hide resolved
lib/provider/api.ts Show resolved Hide resolved
@ehanoc ehanoc merged commit e5c5d6a into main Aug 27, 2024
2 checks passed
@ehanoc ehanoc mentioned this pull request Aug 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehanoc ehanoc ehanoc approved these changes

Assignees

@PhearZero PhearZero

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PhearZero @ehanoc