Eval: Feature/heartbeats #6189
Eval: Feature/heartbeats #6189
Conversation
…ticipationAccounts (#6085) Co-authored-by: John Jannotti <[email protected]>
…AccountData when rnd < 240 (#6165)
Co-authored-by: Gary Malouf <[email protected]>
ledger/apply/challenge.go
Outdated
| } | ||
| challengeHdr, err := headers.BlockHdr(lastChallenge) | ||
| if err != nil { | ||
| panic(err) |
There was a problem hiding this comment.
during catchup, for example, the block DB's window of blocks is moving forward really quickly, and you might reasonably encounter BlockHdr not found errors here
There was a problem hiding this comment.
It turns out you wouldn't even get an error then, it would pull the block from db. Which is good, because if we want to verify blocks with suspensions or free heartbeats in them, we need the value.
But I take your point, and I'll return the empty challenge. Which could cause either of the two things above to fail, but that's reasonable, since something is very wrong.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6189 +/- ##
==========================================
- Coverage 51.88% 50.94% -0.95%
==========================================
Files 639 642 +3
Lines 85489 85831 +342
==========================================
- Hits 44359 43723 -636
- Misses 38320 39298 +978
Partials 2810 2810 ☔ View full report in Codecov by Sentry. |
jannotti
force-pushed
the
feature/heartbeats
branch
from
0fe2ef2 to
cab07e3
Compare
The PR to put heartbeats into main. The new heartbeats/README.md is the best place to look for explaining it.