Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename engine metadata to template_engine #18

Closed
lebouquetin opened this issue Jun 27, 2024 · 1 comment
Closed

rename engine metadata to template_engine #18

lebouquetin opened this issue Jun 27, 2024 · 1 comment

Comments

@lebouquetin
Copy link
Member

lebouquetin commented Jun 27, 2024 •
edited
Loading

For a developer, engine is ok because you can search into source code. As a user, I do not understand what engine is.

I suggest to rename the engine metadata to template_engine.

Also, use a default value to jinja (to be implemented through a specific settings; see #19)
This was referenced Jul 8, 2024
Merged
Merged
@ClmntBcqt
Copy link
Contributor

Merged in #29 and #31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lebouquetin @ClmntBcqt