Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlowCharting 1.0.0 (old 0.9.1) in progress #242

Open
algenty opened this issue Nov 8, 2020 · 61 comments
Open

FlowCharting 1.0.0 (old 0.9.1) in progress #242

algenty opened this issue Nov 8, 2020 · 61 comments
Assignees
Labels

Comments

@algenty
Copy link
Owner

algenty commented Nov 8, 2020

Hi dear users,
I need your feedback for the next version of Flowcharting :

[0.9.1b SNAPSHOT] - 2020-11-08

Added

  • New initialization engine for drawio libs
  • New notifier handler in panel.
  • Change default url draw.io by https://embed.diagrams.net
  • New edit design for grafana v7 (See example)
  • Add shape name and properties in inspect console (See example)
  • Add gaugePos property in Event Mapping for the gauge draw.io models See example)

Fixed

  • Fixed : Inspect mode (issue #209) (See example)
  • Fixed : Label position in shape (issue #147)
  • Fixed : Initialization of first model
  • Fixed : Display refresh between "edit mode" and "dashboard mode" in grafana v7 (issue #205)
  • Fixed : zoom on text without witdth and height
  • Fixed : Disable select text when double click for zoom
  • Fixed : retro compatibility with grafana 6.x (issue #218)
  • Fixed : Zoom when with 2 or mode panels with flowcharting (issue #214)

rulesv7_ani

inspectv7_ani

gaugePos_ani

Download it at
https://algenty.github.io/flowcharting-repository/ARCHIVES.html

BR,
Arnaud

@bijwaard
Copy link

Hi Arnaud,

Great work! New edit design works fine, good to see some more shape detail in inspector. Curious what the Lvl column in the expector is for.

I found some minor issues in 0.9.1b snapshot (tried using firefox and chromium-browser in Linux with grafana 7.2.2):

  • when editing the drawing, I still get warning about app.diagram.net
  • as reported before in edit mode need to fit/fill/exact or enlarge diagram area to see diagram

Kind regards,
Dennis

@algenty
Copy link
Owner Author

algenty commented Nov 10, 2020

Hi Dennis,

Thx for your feedback, if it is an existing panel, you need to change url in flowcharting section by https://embed.diagrams.net.
If you're adding a new panel, url has the good value.

@bijwaard
Copy link

Hi Arnaud,
Yes, that works, thanks.

Note that when no URL is filled in, it will open a browser with grafana main window....
image

@bijwaard
Copy link

Hi Arnaud, all,
I'll be showing our flowcharting and other dashboards as part of the advanced measurement solution in a webinar next week.
Kind regards,
Dennis

@xkilian
Copy link

xkilian commented Nov 14, 2020

Sorry Arnaud, I have no feedback for you at this time, I am not running any Grafana 7.x yet. I was waiting for legacy panels to be converted and all our plugins to be upgraded to be compatible with Grafana 7. The only outstanding issue is worldmap map and alexandra map panels cannot be both installed and used in different dashboards. An odd bug. Keep up the excellent work.

@algenty
Copy link
Owner Author

algenty commented Nov 15, 2020

hi @xkilian
This version works with v6 off course

@xkilian
Copy link

xkilian commented Nov 16, 2020

Ah, I stand corrected, I will give it a try.

@bijwaard
Copy link

bijwaard commented Nov 18, 2020

Hi Arnaud,

I found a bug in v[0.9.1] - 2020-07-04 regarding the threshold section for mapping rules. I've noticed that sometimes only 1 or 2 of the 3 metrics (there should be L1, L2, L3 values for power P) are appended with the label/text mappings (append new line), and I could temporarily work around this by disabling the threshold invert on a number of mapping rules. I used the inspect function to show the metric values, and they were present when this happened.

I can try to test with the newest 0.9.1 snapshot after our webinar this afternoon.
image

Kind regards,
Dennis

@bijwaard
Copy link

bijwaard commented Nov 19, 2020

Hi Arnaud,
I just installed 0.9.1b snapshot in the substation and reverted my work-around. I can reproduce the issue above. Note that it happens mostly with selected influxdb datasource F0. I have not seen it with other selected fields F1..F8 yet. I added the inspect window to show that the metrics are available. I'm also showing the metric definition for Power (P) and its metric usage in the mapping.
image
image

The webinar was a success yesterday, the replay is now available online. The presentation gives more insight in our measurement solution, I guess the live demo is most interesting for grafana/flowcharting users, and shows powerful capabilities of a number of panels and data sources.

  1. The demo starts using alexandra-trackmap to show the location of the measured substations using their GPS coordinates
  2. next the flowcharting panel is used for the substation overview and feeder diagrams
  3. next graph, plotly and SVG panels are used to display phasors, realtime signal and harmonics.
  4. next the flowcharting panel is used to show the DSP flow within/between sensors, and realtime output signals in tooltips.
  5. next the commandline usage of measurements and developing DSPs using measurements via an encrypted tunnel is demonstrated

We use the influxdb datasource for point 2,3 above and the simpod-json datasource for the realtime data (snapshots) in point 3 and 4. Point 1 for now uses the testdata db as datasource.

Kind regards,
Dennis

@algenty
Copy link
Owner Author

algenty commented Nov 19, 2020

Hi Dennis,
Congratulation for your webinar !
For the bug, il don't understand. have you the same pb in 0.9.0 ? it's a regression ?

@bijwaard
Copy link

Hi Arnaud,
Thanks.
I have not tried 0.9.0. Thusfar, I tried 2 snapshots of 0.9.1, the newest one (0.9.1b) and an older snapshot from july.

@algenty
Copy link
Owner Author

algenty commented Nov 19, 2020

@dennis,

I'am watching your webinar, and at 22:30 and for history, i suggest to activate graphover on your dashboard to change color on flowcharting panel too (Ctrl+o). i return to the video ...

PS : Can i share the webinar on twitter ?

@bijwaard
Copy link

bijwaard commented Nov 19, 2020

Hi Arnaud,
You can of course share the webinar on twitter, the more publicity the better;-)
I tried with the graphover, didn't know this feature, and now my issue now changes to 1, 2, and three values whenever I hover between graph panel and flowcharting panel, see movie below. I now also see the same for rms (current) in the Feeder.
vokoscreen-2020-11-19_14-00-15.mkv.zip
Forgot to capture the power graph with (bottom right), but it doesn't show obvious holes in the graphs.
image

Kind regards,
Dennis

@dennis
Copy link

dennis commented Nov 19, 2020

@algenty Keep in mind, you might trigger an notification when you do @[username]

@xkilian
Copy link

xkilian commented Nov 29, 2020

I am finally doing a test run this week on flowcharting beta with Grafana 6.7, do you have a newer version to test or is it still pertinent to test the current beta?

@xkilian
Copy link

xkilian commented Dec 5, 2020

All my dashboards are functional.
Suggestions:

  • Documentation: When attaching multiple rules to the same object, links should be handled at the draw.io layer and not in the plugin, because then you need to add the link to all rules that relate to the object, otherwise depending on which rule is the active on, the link may not be available. I use this to show metrics and coloring based of Prometheus ALERTS metrics states on top of a simple metric show availability (like a ping metric).
  • Thank you for the coloring change on edit button. :-)
  • Having learned to use label_replace function of PromQ, to reduce the number of caracters in my legends they now fit in popup graph legends without wrapping.
  • The editing interface, with 200 hundred rules defined loads about as quick as the old version. Nothing noticeable in any case. But once loaded, it is very responsive and I like the new rule liste UI, it is more compact, no need click from right to left everytime you need to clone and edit.. 👍

I will proceed to testing the shared crosshairs with my metrics and changes based on state or metrics. Thank you for your work.

@algenty algenty changed the title FlowCharting 0.9.1 in progress FlowCharting 1.0.0 in progress Dec 6, 2020
@algenty algenty changed the title FlowCharting 1.0.0 in progress FlowCharting 1.0.0 (old 0.9.1) in progress Dec 6, 2020
@algenty
Copy link
Owner Author

algenty commented Dec 6, 2020

thx @xkilian and @bijwaard for you feedback
I rename 0.9.1 with 1.0.0.
For this version, a big work on UX Design and prepartion for multi diagram.

[1.0.0a SNAPSHOT] - 2020-12-06

TODO

  • Disable anim not work
  • message console size
  • display zoom percent
  • align icons
  • Column resize
  • Size of plugin

Added

  • New initialization engine for drawio libs
  • New draw.io libs (13.10.9)
  • New notifier handler in panel.
  • Change default url draw.io with https://embed.diagrams.net
  • New edit design for grafana v7 (See example)
  • New UX design and new concept "fast edit" :
    • Can edit without expand rules and flowcharts with icons
    • Advanced/detail mode on expand.
  • Add shape name and properties in inspect console (See example)
  • Add gaugePos property in Event Mapping for the gauge draw.io models See example)
  • Plugin is signed
  • Add Light theme support
  • New thresholds on dates (accept units like d, w, m, y, h, s or a date)
  • Can Enable/Disable each element.
  • Colors (threshold and background) can be empty.

Fixed

  • Fixed : Inspect mode (issue #209) (See example)
  • Fixed : Label position in shape (issue #147)
  • Fixed : Initialization of first model
  • Fixed : Display refresh between "edit mode" and "dashboard mode" in grafana v7 (issue #205)
  • Fixed : zoom on text without witdth and height
  • Fixed : Disable select text when double click for zoom
  • Fixed : retro compatibility with grafana 6.x (issue #218)
  • Fixed : Zoom with 2 or more FlowCharting (issue #214)
  • Fixed : Background color edition in flowchart tab

design_7_2

Now, the plugin is signed
image

Still some bugs like column resize or format message in console.

@bijwaard
Copy link

bijwaard commented Dec 6, 2020

Hi Arnaud,

Great work, you have been busy!
I would like to test it, but the download does not seem to work for me. Moreover, the new 1.0.0a snapshot does not (yet) show up in the archive list and changelog.

Kind regards,
Dennis

@algenty
Copy link
Owner Author

algenty commented Dec 6, 2020

pushed, try again

@bijwaard
Copy link

bijwaard commented Dec 6, 2020

Great, thanks!

@bijwaard
Copy link

bijwaard commented Dec 6, 2020

Hi Arnaud,

Here is my first feedback for 1.0.0a:

  • nice that you can now do basic operations on the collapsed rules and inspect items
  • maybe you can make the different mapping categories/types collapsible as well, since rules are often longer than a page
  • I notices the button "Reduce the rule" at the bottom of an expanded rule, you may want to rename it to "Collapse" and change its tooltip from "Refresh/apply" to something else.
    image
  • in the inspect, the labels do not expand the placeholders, this could also be done through a tooltip like is done for the shapes
    image
  • still not sure what the Lvl column is for in the inspector
  • some performance tweaks may be required to speed up Panel Edit, uncollapse list of mapping Rules, etc.

Kind regards,
Dennis

@algenty
Copy link
Owner Author

algenty commented Dec 6, 2020

ok, thx @bijwaard for this feedback

@algenty algenty self-assigned this Dec 6, 2020
@algenty algenty pinned this issue Dec 6, 2020
@xkilian
Copy link

xkilian commented Dec 6, 2020

Are dashboard variables supported, so that we can make a generic dashboard? (if the layout is always the same and the object ids remain consistent, or could be named to match a variable) We have lots of recurring system patterns that could modeled in flowcharting.

Even in rules, when cloning rules I often find myself changing always the same key in the rule name, metric filter and URL and the only unique thing is the mapping to the object. Definately need to find some way to have rules autogenerated based on template variables and pre-defined object IDs that could match the same variable name. This would make my 200 rules be generated in two template rules. I think you are not far from being able to do this.

Great job, I will run off and test this new version and hopefully have some intelligent feedback. :-)

@algenty
Copy link
Owner Author

algenty commented Dec 8, 2020

Hi my best beta users @xkilian, @bijwaard and @CrashLaker.
In this beta, i introduce to you the concept of "fast edit" : Change metric name and targets very fast with only one button.
Create your rule model, duplicate it and change targets and metric name.

fastedit_ani

[1.0.0b SNAPSHOT] - 2020-12-08

TODO

  • Disable anim not work
  • display zoom percent
  • align icons
  • Size of plugin
  • Styles on firefox

Added

  • New initialization engine for drawio libs
  • New draw.io libs (13.10.9)
  • New notifier handler in panel.
  • Change default url draw.io with https://embed.diagrams.net
  • New edit design for grafana v7 (See example)
  • New UX design and new concept "fast edit" :
    • Can edit without expand rules and flowcharts with icons
    • Advanced/detail mode on expand.
    • Fast edit mode
  • Add shape name and properties in inspect console (See example)
  • Add gaugePos property in Event Mapping for the gauge draw.io models See example)
  • Plugin is signed
  • Add Light theme support
  • New thresholds type : dates (accept units like d, w, m, y, h, s or a date)
  • New event mapping operators
  • Can Enable/Disable each element.
  • Colors (threshold and background) can be empty.

BR
Arnaud

@kenizhou
Copy link

Thanks for your great works!

@x70b1
Copy link
Contributor

x70b1 commented Jun 1, 2021

Is it still an issue that we can't replace google fonts with dynamic text (#203)? Sorry, I can't test this at the moment.
A solution would be awesome!

@nmbath
Copy link

nmbath commented Jun 24, 2021

I am running FlowCharting 1.0.0(a), a great plugin and will be very handy.

I have run into a problem. When my InfluxDB returns no data, the label from the digram is displayed. Is there anyway to not display the label. It seems a little like a bug from #65, which was fixed.

Any guidance?

image

image

@RedShift1
Copy link

@nmbath I won't be able to help you with your issue but I like how your diagram looks. Would you mind sharing a screenshot of the entire thing?

@bijwaard
Copy link

Hi nmbath,

I have run into a problem. When my InfluxDB returns no data, the label from the digram is displayed. Is there anyway to not display the label. It seems a little like a bug from #65, which was fixed.

I assume you use a text mapping rule to replace the contents of the label. You can try to make the label empty (or some spaces) in your draw.io diagram.

Kind regards,
Dennis

@nmbath
Copy link

nmbath commented Jul 27, 2021

@bijwaard Thank you or the idea, that worked.

@neshorg
Copy link

neshorg commented Sep 10, 2021

Hello Everyone!

Is anyone using the 8.1.3 OSS version? I'm experiencing that this plugin version [1.0.0b] "prevents" you from accessing the plugin page through the menus "Configuration>plugins" and "Server Admin>plugins" with the following error:
image

Other than that, everything seems to be working fine while being used on dashboards. The plugin page seems to be the only problem, probably due to accessing other checks/validations.
I'm considering to revert back to 8.1.1 for the time being which still works fine with 1.0.0b.

@bijwaard
Copy link

bijwaard commented Sep 10, 2021

Hi neshorg,
Thanks for trying the new grafana release, I just gave it a spin myself. I cannot reproduce your error via Configuration/plugins, and don't have the ServerAdmin/plugins menu item.
The build-in shapes are back in my dashboards, and it seems to solve tickets #313, #314, and hopefully #312.
Here is the relevant blank shape fix in the grafana changelog

  • Plugins: Track signed files + add warn log for plugin assets which are not signed. #38938

Kind regards,
Dennis

@neshorg
Copy link

neshorg commented Sep 10, 2021

Hello Dennis,

Thanks for replying and testing! I've since then gone back to 8.1.1 and strangely still got the same error with 1.0.0b (even though this worked nicely with 8.1.1 in the past). So the upgrade to 8.1.3 might've broken more stuff than my backed-up grafana.db can "restore".
I even tested 1.0.0a on 8.1.1 and still got the same error. So for now I was forced to go all the way back to 0.9.1 which does work.

Other thing I can think of is that I'm running this grafana instance on a windows VPS...not sure if this has anything to do with my specific error during grafana upgrade/downgrade compared to a different OS environment.

Lastly, I can't remember ever having trouble with built-in shapes or anything related to shapes.
The only thing that comes to mind is not being able to choose a different threshold value in the "when" column under Event/Animation Mappings of a rule. I always seem to only get the "All" option while definitely having different thresholds configured which should be recognized in this stage.

@raphaelrrl
Copy link

Hi guys, I've been testing flowcharting and the new improvements are perfect.
your work is amazing @algenty , thanks for sharing.

@Teofaness
Copy link

Hello guys! I have the problem using the zabbix problems data source. When selecting apply metric , it returns with repeated values, as shown in the image:
image

@bijwaard
Copy link

With influx/ql and some other data sources, you can use aliases for metics using tags and template variables, does zabbix have something like that?
What else can you "show" besides "problems"?

@isaqueprofeta
Copy link

isaqueprofeta commented Mar 26, 2022

Hello guys! I have the problem using the zabbix problems data source. When selecting apply metric , it returns with repeated values, as shown in the image: image

It's repeated because you have two queries. And this two queries aren't merged from the datasource to the front-end processing, then you have two "Problems" : one from the query A and another from query B.

@cardosocristian
Copy link

Is it possible to support Grafana 9?

@algenty
Copy link
Owner Author

algenty commented Jul 17, 2022 via email

@iamelec
Copy link

iamelec commented Oct 3, 2022

Is it possible to add support for opening links in current tab when adding a link mapping within the flowcharting plugin in Grafana? Right now it opens in a different tab, which gives problems when embedding my dashboard in a iframe within a different program (as I can only navigate by using links which open in current tab).

@mirackle-spb
Copy link

it is again DEAD project? :)
Maybe you can move this project to grafana main code repository?

@x70b1
Copy link
Contributor

x70b1 commented Nov 25, 2022

@mirackle-spb
Copy link

@x70b1

Grafana killed this prioject already: https://grafana.com/docs/grafana/latest/panels-visualizations/visualizations/canvas/

What Grafana did is a child's toy. I can't seem to compare these two plugins. This plugin gives orders of magnitude more opportunities for real engineering graphics than the "craft" that Grafana made.

@xkilian
Copy link

xkilian commented Nov 25, 2022

I have to agree, they (grafana labs) have not approached the plugin from the right mindset.
I have provided feedback, but it will not change for the medium term.
Flowcharting is absolutely relevant and should get commercial support/donations if the maintainer expresses more interest in continuing to develop it. Ideally he should wrap up a stable version and open up the dev to more people or look for a new maintainer.
It is too useful a plugin. We depend on it for lots of operation and support instances.

@ftoledo
Copy link

ftoledo commented Feb 13, 2023

@x70b1

Grafana killed this prioject already: https://grafana.com/docs/grafana/latest/panels-visualizations/visualizations/canvas/

What Grafana did is a child's toy. I can't seem to compare these two plugins. This plugin gives orders of magnitude more opportunities for real engineering graphics than the "craft" that Grafana made.

I agree, but unfortunately flowchart is still too unstable for production use.
I think that if they manage to fix these bugs related to mapping. It's fully usable

@joshis9
Copy link

joshis9 commented Apr 17, 2023

Hi Arnaud,

great work!
I changed the default url but after I save my work, the panel is just black.
Do you have any ideas?

@SanderLam
Copy link

Hi there!

Thank you for the work so far, this all looks amazing!

So I was wondering what the current status is of releasing 1.0.0 as a version in the Grafana plugin?

I understand we're talking open-source here and no promises at all of course! Just curious if any development is still ongoing.

@ftoledo
Copy link

ftoledo commented Apr 21, 2023

Hi there!

Thank you for the work so far, this all looks amazing!

So I was wondering what the current status is of releasing 1.0.0 as a version in the Grafana plugin?

I understand we're talking open-source here and no promises at all of course! Just curious if any development is still ongoing.

My feeling is that the project is a bit abandoned

@SanderLam
Copy link

My feeling is that the project is a bit abandoned

So I feel that as well, which is why I hope that at least version 1.0.0 can be released.
It already has critical improvements over version 0.9.1, which is currently available for Grafana and I would love to use the plugin for my project.

@ninkaninus
Copy link

@algenty What do you need to proceed with developing this awesome dashboard plugin?

@ftoledo
Copy link

ftoledo commented Jul 5, 2023

@algenty What do you need to proceed with developing this awesome dashboard plugin?

i can send few beers!

imagen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests