Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merger #147

Open
BayBreezy opened this issue Oct 17, 2024 · 7 comments
Open

Merger #147

BayBreezy opened this issue Oct 17, 2024 · 7 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@BayBreezy
Copy link

Feature request

Summary

Hey,

I was able to use the new plugin SDK that Strapi provides to create a version that is compatible with Strapi5. We were having a discussion over here: BayBreezy/strapi-plugin-email-designer-5#10 about merging both plugins so that there is no confusion when users want to use the email designer.

We would love to hear what you think about this. Feel free to check the thread to see what we discussed over there.

Why is it needed?

To cause less confusion among Strapi users.

Suggested solution(s)

Find some way to merge the new plugin into this one.

Related issue(s)/PR(s)

N/A

@alexzaganelli alexzaganelli self-assigned this Oct 17, 2024
@alexzaganelli alexzaganelli added the help wanted Extra attention is needed label Oct 17, 2024
@alexzaganelli
Copy link
Owner

Hi @BayBreezy , thank you for your work on the forked repository and for addressing this issue. I truly appreciate the effort. To be transparent, I’ve stepped back a bit from the development of this project due to the increasing number of feature requests without much contribution to the actual development. It’s encouraging to see the community take initiative, and I hope more developers will continue to get involved.

I’d be happy to review a pull request if you decide to submit one to the main repo. However, before publishing any updates, it would be necessary to involve a few testers (besides myself) to ensure everything runs smoothly considering that this plugin is downloaded thousand and thousand times per weeks ( NPM Link ) .

@boazpoolman
Copy link

boazpoolman commented Oct 17, 2024

I would like to help testing when a beta is ready!

@alexzaganelli alexzaganelli added the enhancement New feature or request label Oct 17, 2024
@begservice
Copy link

if i get it running i will help as well

@boazpoolman
Copy link

In terms of next steps; @BayBreezy can you draw up a PR with your changes?

@BayBreezy
Copy link
Author

Ehhhh.. I am not even sure where to start.
Do i just for this repo and put my changes on a new branch?

@boazpoolman
Copy link

Yep, that's about it!

@BayBreezy
Copy link
Author

Cool cool.
The plugin just got placed on the marketplace btw.
Do we still move forward with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants