Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling analytics causes a runtime exception #17

Open
CodingGorilla opened this issue Mar 24, 2021 · 0 comments
Open

Disabling analytics causes a runtime exception #17

CodingGorilla opened this issue Mar 24, 2021 · 0 comments

Comments

@CodingGorilla
Copy link

Describe the bug
Checking the 'Disable Analytics' box in the task configuration causes a TypeError to be thrown at runtime. The full error from the output is:

TypeError: Cannot read property 'commonProperties' of undefined
    at AnalyticsService.extendProperties (/home/vsts/work/_tasks/AngularCLI_74b00cae-14b5-414f-b9f1-1aa71b192da2/1.0.0/services/analytics.service.js:50:106)
    at /home/vsts/work/_tasks/AngularCLI_74b00cae-14b5-414f-b9f1-1aa71b192da2/1.0.0/index.js:111:27
build /home/vsts/work/1/s -c stg --verbose true true
    at step (/home/vsts/work/_tasks/AngularCLI_74b00cae-14b5-414f-b9f1-1aa71b192da2/1.0.0/index.js:33:23)
    at Object.next (/home/vsts/work/_tasks/AngularCLI_74b00cae-14b5-414f-b9f1-1aa71b192da2/1.0.0/index.js:14:53)
    at /home/vsts/work/_tasks/AngularCLI_74b00cae-14b5-414f-b9f1-1aa71b192da2/1.0.0/index.js:8:71
    at new Promise (<anonymous>)
    at __awaiter (/home/vsts/work/_tasks/AngularCLI_74b00cae-14b5-414f-b9f1-1aa71b192da2/1.0.0/index.js:4:12)
    at run (/home/vsts/work/_tasks/AngularCLI_74b00cae-14b5-414f-b9f1-1aa71b192da2/1.0.0/index.js:98:12)
    at Object.<anonymous> (/home/vsts/work/_tasks/AngularCLI_74b00cae-14b5-414f-b9f1-1aa71b192da2/1.0.0/index.js:173:1)
    at Module._compile (internal/modules/cjs/loader.js:778:30)

The task continues to actually execute and seems to still run the ng command properly.

To Reproduce
Steps to reproduce the behavior:

  1. Expand the logging node on the task configuration
  2. Click the 'Disable logging' checkbox
  3. Run the pipeline
  4. See error

Expected behavior
The analytics are disabled and the task runs without producing exception(s).

Azure Devops Agent (please complete the following information):

  • OS: Happened on both 'windows-2019' and 'ubuntu-20.04' agents

Angular CLI (please complete the following information):

  • Version 1.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant