Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Posframe doesn't hide automatically on moving the point out of the error line #27

Open
Gleek opened this issue Feb 23, 2021 · 6 comments

Comments

@Gleek
Copy link

Gleek commented Feb 23, 2021

This might be an issue in recent updates of posframe but flycheck-posframe has stopped hiding automatically once moved out of the error line. It stays open until I hover on it with my mouse or change my focus to the minibuffer.

I have solved it by running the flycheck posframe hide on post-command-hook.

(add-hook 'post-command-hook #'flycheck-posframe-hide-posframe)
@zhenwenc
Copy link

@Gleek Do you notice quite sticky when moving the cursor up/down after having this hook?

@alexmurray
Copy link
Owner

Apologies for taking so long to get to this issue, I expect to have a fix ready later this morning.

alexmurray added a commit that referenced this issue Mar 15, 2021
We also need to hide when point moves away for the error etc. Together with
the previous commit this should resolve issue #27 for now.
@alexmurray
Copy link
Owner

This should be fixed now - a new package should be available on MELPA with this fix within ~24 hours.

@mattsawyer77
Copy link

hi @alexmurray, it seems the original issue returned with the recent commit 9113684. It seemed to work properly for me with the previous commit 6eea204.

If it helps, I'm using doom-emacs with lsp and lsp-ui.

@alexmurray
Copy link
Owner

Damn, ok I have a new implementation in 8f60c9b - let me know if that works any better - or if anyone notices any other weirdness...

@alexmurray alexmurray reopened this Mar 16, 2021
@mattsawyer77
Copy link

thanks @alexmurray ! 8f60c9b seems to work perfectly for me.

snyball added a commit to snyball/doom-emacs that referenced this issue Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants