Add support for upcoming cocotb 2.0 #91
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On upcoming cocotb 2.0 cocotb.SIM_NAME may not exist at all. On cocotb 1.x it was set to None. Checking for existence of SIM_NAME supports both cocotb 2.0 and 1.x.
binstr is read only property on upcoming cocotb 2.0
On upcoming cocotb 2.0 such conversion is deprecated and will eventually always return True. The recommended replacement is to convert to string and then compare. On cocotb 1.9 explicit conversion to string is no longer necessary. Once this is minimum version of cocotb supported by cocotbext-axi, the explicit conversions can be dropped.
The .data field of cocotb.triggers.Event has been removed in cocotb 2.0. This is a part of the API exposed by cocotbext-axi. It is probably best to keep the current API until support for cocotb 1.x has been removed from cocotbext-axi. Accordingly, the simpliest solution for this problem is to detect cocotb 2.0 version and re-add the .data field when event.set is being called on cocotb 2.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for upcoming cocotb 2.0 release in a way that both cocotb 1.x and cocotb 2.x can be supported with minimal maintenance overhead.
Fixes #88.
In order to test with cocotb master, the following patch needs to be applied to pick newer dependencies:
PRs to cocotb-bus and cocotb-test have been opened themperek/cocotb-test#263, cocotb/cocotb-bus#83, so sometime soon it will be possible to test by pinning to some commit in the master branches of these projects and sometime later a released version can be used.