Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Builder#append should set checksum #126

Open
taralx opened this issue Sep 28, 2017 · 1 comment
Open

Builder#append should set checksum #126

taralx opened this issue Sep 28, 2017 · 1 comment

Comments

@taralx
Copy link

taralx commented Sep 28, 2017

It makes no sense for the default API to allow users to create bad tar files -- for ease of use the checksum should be set by the Builder, not by the caller.
@alexcrichton
Copy link
Owner

Seems plausible to me! I think this'd be a breaking change but this could always happen in the next major version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexcrichton @taralx