Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax loggerinterface requirement #9

Open
benrcole opened this issue Feb 6, 2023 · 1 comment
Open

Relax loggerinterface requirement #9

benrcole opened this issue Feb 6, 2023 · 1 comment

Comments

@benrcole
Copy link

benrcole commented Feb 6, 2023

Would it be acceptable to relax the definition of the logging for this library so that any PSR\Logger\LoggerInterface can be used?

I'm using this as part of a wider system and want to use the centralised loggers but the requirement for smpp\LoggerInterface is causing me problems.

If that's acceptable I'll submit a suggestion and a pull request.

@alexandr-mironov
Copy link
Owner

Hello, yeap, its acceptable,
smpp\LoggerInterface is clone of PSR\Logger\LoggerInterface, im understand its not a best solution but has not enough motivation to fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants