From 7c8107a4127fb59c94e16bab7f9fb4827e9652cd Mon Sep 17 00:00:00 2001 From: LucioMS Date: Wed, 14 Jun 2023 10:59:26 -0700 Subject: [PATCH] chore: improving a comment to refer to an issue --- lib/controllers/authorization-controller/index.js | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/lib/controllers/authorization-controller/index.js b/lib/controllers/authorization-controller/index.js index df80f9ec..fa30712d 100644 --- a/lib/controllers/authorization-controller/index.js +++ b/lib/controllers/authorization-controller/index.js @@ -149,13 +149,12 @@ module.exports = class AuthorizationController { const requestUrl = request.url; const requestQuery = url.parse(requestUrl, true).query; + // Response from the browser with authentication code if (requestUrl.startsWith("/cb?code")) { response.end(messages.ASK_SIGN_IN_SUCCESS_MESSAGE); ui.confirmAllowSignIn((error, confirmSignInChoice) => { - // After confirmed or not browser sign in, closes the socket/port - // with server.destroy(). - // We need to keep the port open so a local hacker is not be able to - // open that port until we get an answer in confirmAllowSignIn + // Closing the socket port with server.destroy() only after confirmation question. + // See https://github.com/alexa/ask-cli/issues/476 server.destroy(); if (error) {