Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed the index.js bundle inside of npm releases #37

Open
mensfeld opened this issue Apr 11, 2022 · 3 comments
Open

Embed the index.js bundle inside of npm releases #37

mensfeld opened this issue Apr 11, 2022 · 3 comments

Comments

@mensfeld
Copy link

Hey, I noticed, that part of apl-viewhost-web is being downloaded. This causes a problem when trying to install offline / from cache because part of the code is being fetched from: https://d1gkjrhppbyzyh.cloudfront.net/apl-viewhost-web/6990ED81-A690-4946-8ACC-63B243C19388/index.js

Is there a chance to bundle this inside the upcoming releases?

@pose
Copy link

pose commented Nov 8, 2022

Hi,

I would like to +1 this request since this is attempting to downloading an opaque artifact without customer knowing constituting a security risk. Could you model this dependency properly using npm?

Thanks,

@zhamingc
Copy link
Contributor

Thanks for reaching out to us. That index.js contains the WebAssembly pre-compiled binary of APL Core Engine. We hear your concern, and will look into this.

@pose
Copy link

pose commented Jan 17, 2023

I'm not an expert on the APL Core Engine and what language is written in, but in Rust there are already existing solutions that could be leverage to generate a proper npm package: https://rustwasm.github.io/wasm-pack/book/commands/pack-and-publish.html

Once it's modeled as an npm package, you should be able to depend on it and remove that download from the Internet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants