Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include API documentation on SMAPI SDK types. #17

Open
sam-goodwin opened this issue Feb 12, 2021 · 1 comment
Open

Include API documentation on SMAPI SDK types. #17

sam-goodwin opened this issue Feb 12, 2021 · 1 comment
Labels

Comments

@sam-goodwin
Copy link

SMAPI SDK types don't include much documentation. This introduces friction for developers by requiring they leave the context of the IDE to understand how to use the code. We should make sure to include comprehensive documentation on the types so that developers can jump around the types to learn and understand how it works.

For example, request payloads don't explain the request type or its fields:

/**
 *
 * @interface
 */
interface CreateSkillRequest {
  'vendorId'?: string;
  'manifest'?: v1.skill.Manifest.SkillManifest;
  'hosting'?: v1.skill.AlexaHosted.HostingConfiguration;
}

Functions only describe arguments, not the API:

/**
 *
 * @param {string} catalogId Provides a unique identifier of the catalog
 * @param {string} nextToken When response to this API call is truncated (that is, isTruncated response element value is true), the response also includes the nextToken element. The value of nextToken can be used in the next request as the continuation-token to list the next set of objects. The continuation token is an opaque value that Skill Management API understands. Token has expiry of 24 hours.
 * @param {number} maxResults Sets the maximum number of results returned in the response body. If you want to retrieve fewer than upper limit of 50 results, you can add this parameter to your request. maxResults should not exceed the upper limit. The response might contain fewer results than maxResults, but it will never contain more. If there are additional results that satisfy the search criteria, but these results were not returned, the response contains isTruncated = true.
 */
listUploadsForCatalogV0(catalogId: string, nextToken?: string, maxResults?: number): Promise<v0.catalog.upload.ListUploadsResponse>;

Can we re-use the public documentation or do we need more specific documentation for the code?

@doiron doiron added the docs label Apr 28, 2022
@rahulawl
Copy link
Contributor

Is this issue/feature-request still relevant?
We are working on prioritization of relevant issues and cleanup of rest. If we don’t hear back in 2 weeks, we will assume that the issue is not relevant and we will close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants