Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set numbers shaders to show nothing outside game #3

Open
looooph opened this issue Sep 6, 2020 · 7 comments
Open

Set numbers shaders to show nothing outside game #3

looooph opened this issue Sep 6, 2020 · 7 comments

Comments

@looooph
Copy link

looooph commented Sep 6, 2020

As described in topic

Especially when used in tournament play, it looks "untidy", as it tries to make sense of the tetris background, showing random numbers(see picture below)

image

@alex-ong
Copy link
Owner

alex-ong commented Sep 6, 2020

Use nestrisautolayout to fix this

@alex-ong
Copy link
Owner

alex-ong commented Sep 6, 2020

Color correct
Nestrissharpener
Nestrissharpener numbers (probably need 3-5)
Nestrisautolayout

Edit (this order is wrong, read below)

@looooph
Copy link
Author

looooph commented Sep 6, 2020

Ah, I wasn't even aware of the layout one. But can't use it due to it not yet being Linux compatible.

@alex-ong
Copy link
Owner

alex-ong commented Sep 6, 2020

Is the tournament over yet? So i know whether i should prioritize anything; also your hydrantdude same rng patch is a little out of date; feel free to visit CTM for latest one

@looooph
Copy link
Author

looooph commented Sep 7, 2020

Yes, it was the german championship, happening two days ago. But as I'm one of the very few linux users in the community, there is no hurry at all. But I'll gladly assist in testing once there is a linux version of the autolayout.

@looooph
Copy link
Author

looooph commented Sep 8, 2020

Did some testing, loooph was diligent. If I got this right the autolayout is designed to work with unmodded stencil ready scenes only, so I set everything up accordingly. Still I found two things not displaying correctly:
On Press start screen, the sharpened level shows.
On Music select screen, the sharpened current score(not top) shows the upper 5 digits.

Added pictures to clarify
image

@alex-ong
Copy link
Owner

alex-ong commented Sep 8, 2020

I got the filter order wrong; sorry. But once you get the order correct, you should be able to verify that inside the field area everything is correct, with the "wrong numbers" showing up outside. After I add "blank" as a valid number in the algo it should all work.

note order:
Make Stencil ready scene
Apply scene filters

  • Nestrissharpener (blocks/field)
  • NestrisAutolayout
  • sharpen numbers (3x) (all these areas are outside the field; autolayout puts all other content inside the field)

Final Scene: crops from stencil ready scene that has filters

You should get garbage/randoms but they'll all be outside field area.

Then once we patch it to recognize black == show black, it should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants