Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(provider,rpc,sim): fix typos #469

Merged
merged 2 commits into from
Oct 27, 2023
Merged

chore(provider,rpc,sim): fix typos #469

merged 2 commits into from
Oct 27, 2023

Conversation

GoodDaisy
Copy link
Contributor

@GoodDaisy GoodDaisy commented Oct 16, 2023 •
edited
Loading

No description provided.

@codecov
Copy link

codecov bot commented Oct 16, 2023 •
edited
Loading

Codecov Report

Merging #469 (593b260) into main (1cccb9f) will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

Files Coverage Δ
crates/rpc/src/eth/api.rs 37.60% <100.00%> (ø)
crates/provider/src/ethers/entry_point.rs 0.00% <0.00%> (ø)
Flag Coverage Δ
unit-tests 52.60% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <ø> (ø)
builder 47.67% <ø> (ø)
dev 0.00% <ø> (ø)
pool 59.92% <ø> (ø)
provider 1.33% <0.00%> (ø)
rpc 18.26% <100.00%> (ø)
sim 82.20% <ø> (ø)
tasks ∅ <ø> (∅)
types 93.56% <ø> (ø)
utils 7.20% <ø> (ø)

@0xfourzerofour
Copy link
Collaborator

please use conventional commit messages.

You can refer to https://www.conventionalcommits.org/en/v1.0.0/

@GoodDaisy GoodDaisy changed the title fix typos chore(provider,rpc,sim): fix typos Oct 27, 2023
@GoodDaisy
Copy link
Contributor Author

@0xfourzerofour Thanks for your review.
And I have changed to use conventional commit messages.

0xfourzerofour
0xfourzerofour approved these changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@0xfourzerofour 0xfourzerofour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@0xfourzerofour 0xfourzerofour merged commit ed31bd8 into alchemyplatform:main Oct 27, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xfourzerofour 0xfourzerofour 0xfourzerofour approved these changes

@dancoombs dancoombs Awaiting requested review from dancoombs dancoombs is a code owner

@dphilipson dphilipson Awaiting requested review from dphilipson dphilipson is a code owner

@alex-miao alex-miao Awaiting requested review from alex-miao alex-miao is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GoodDaisy @0xfourzerofour