Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit LocalPoolServer interface #277

Closed
dancoombs opened this issue Jul 31, 2023 · 1 comment · Fixed by #328 or #324
Closed

Revisit LocalPoolServer interface #277

dancoombs opened this issue Jul 31, 2023 · 1 comment · Fixed by #328 or #324
Assignees
@dancoombs
Labels
enhancement New feature or request
Milestone
0.1.0-beta

Comments

@dancoombs
Copy link
Collaborator

#268 (comment)

https://alchemyinsights.slack.com/archives/C04RHSDSP9U/p1690842255615569
@dancoombs dancoombs added the enhancement New feature or request label Jul 31, 2023
@dancoombs dancoombs added this to the 0.1.0-beta milestone Jul 31, 2023
@dancoombs dancoombs self-assigned this Jul 31, 2023
@dancoombs dancoombs mentioned this issue Jul 31, 2023
Merged
@dancoombs dancoombs modified the milestones: 0.1.0-beta, 0.1.0 Aug 7, 2023
@dancoombs
Copy link
Collaborator Author

Also, instead of passing in a client mode, the CLI should construct and pass in the client itself.

@dancoombs dancoombs mentioned this issue Aug 23, 2023
Merged
@dancoombs dancoombs linked a pull request Aug 29, 2023 that will close this issue
refactor: rework the pool server classes #328
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dancoombs dancoombs

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.1.0-beta
1 participant
@dancoombs