feat: add email OTP support #1163
Draft
+448
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “graphite-merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
dphilipson
commented
Nov 19, 2024
| ); | ||
| // Helper type to ensure that a listener is either defined or explicitly | ||
| // omitted for every event type. | ||
| type Listeners = { |
There was a problem hiding this comment.
@moldy530 I kept forgetting to add listeners for new events I added so I changed this so the type system would help. Style question: do you prefer using undefined for events where we don't want a listener, or the noop function () => {}?
|
In draft mode because we don't have final designs (and also the backend isn't done yet). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
yarn test)sitefolder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change)yarn lint:check) and fix any issues? (yarn lint:write)PR-Codex overview
This PR introduces support for One-Time Password (OTP) authentication in the account kit. It expands existing types and interfaces, modifies authentication flows, and adds new components for handling OTP verification.
Detailed summary
Sessiontype to includeotp.AWAITING_OTP_AUTHstatus.assertNeverfunction to accept additional parameters.authTypein metrics to includeotp.otp_verify.OtpParamstype for OTP requests.submitOtpCodemethod inAlchemySignerWebClient.LoadingOtpandCompletingOtpAuthcomponents for OTP flow.