Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor for a tab waiting for a long-running query remains editable #2178

Open
depombo opened this issue Mar 10, 2023 · 3 comments
Open

Editor for a tab waiting for a long-running query remains editable #2178

depombo opened this issue Mar 10, 2023 · 3 comments
Labels
bug Something isn't working dashboard

Comments

@depombo
Copy link
Member

depombo commented Mar 10, 2023

We should probably prompt them to open a new tab

@depombo depombo converted this from a draft issue Mar 10, 2023
@depombo depombo added bug Something isn't working dashboard labels Mar 10, 2023
@aguillenv
Copy link
Contributor

Hmm, not sure, it is true they can change the query but they will not be able to execute in that tab again until the current execution is done

@dfellis
Copy link
Member

dfellis commented Mar 10, 2023

The one advantage of the psql-inspired UI concept was that once you submit the query, that query pops backwards into the history and clears the (smaller) editor area for continued editing.

The "equivalent" here would be opening a new tab each time you submit a query, which would be weird.

I kinda agree with @depombo that when the Run Query button is disabled the editor should also be disabled, so when the results come back you're 100% certain what the query was that produced the table you're looking at, because the user can open a new tab to start working on another query in the meantime if they want.

But that also might be annoying if you know you need to make just a small change to a large query for your next query, so I'm not sure about this.

@depombo depombo moved this from Todo to Backlog in IaSQL Sprint Board Mar 13, 2023
@depombo
Copy link
Member Author

depombo commented Mar 13, 2023

We will wait to see if this comes up more often and assess how we want to handle it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dashboard
Projects
None yet
Development

No branches or pull requests

3 participants