-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change sic1d07 to letters #53
Comments
For ref, the new businessRegistry.csv.gz. Note that Ids have changed slightly. |
As you mention the letters run from |
@dabreegster is best placed to confirm which parts of the code should be changed |
What exactly is the ask here? The output proto is already a letter: Line 115 in 108794b
Is businessRegistry.csv changing? If so, then a small amount of code changes internally. See uatk-spc/src/init/commuting.rs Line 75 in 108794b
uatk-spc/src/init/commuting.rs Line 274 in 108794b
Edit: I didn't read clearly -- so the registry csv is changing. Should be a very easy change in this code |
Initial modifications (9d145dd), yet to be tested on the updated file. |
The population data loaded by SPC has letters for sic1d07, while the business registry has numbers (A = 1, B = 2, etc.). This means that there is a conversion happening somewhere during the commuting modelling. The new business registry will have a letter directly. The code needs to be adapted accordingly.
The text was updated successfully, but these errors were encountered: