Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change sic1d07 to letters #53

Open
HSalat opened this issue Apr 27, 2023 · 5 comments
Open

Change sic1d07 to letters #53

HSalat opened this issue Apr 27, 2023 · 5 comments
Assignees

Comments

@HSalat
Copy link
Collaborator

HSalat commented Apr 27, 2023

The population data loaded by SPC has letters for sic1d07, while the business registry has numbers (A = 1, B = 2, etc.). This means that there is a conversion happening somewhere during the commuting modelling. The new business registry will have a letter directly. The code needs to be adapted accordingly.

@HSalat
Copy link
Collaborator Author

HSalat commented Apr 27, 2023

For ref, the new businessRegistry.csv.gz.

Note that Ids have changed slightly.

@sgreenbury
Copy link
Collaborator

As you mention the letters run from A-U it's probably easiest to use a char instead of the current u32. We could also add a type Sic1d2007 = char; for clarity. Happy to implement this.

@HSalat
Copy link
Collaborator Author

HSalat commented Apr 27, 2023

@dabreegster is best placed to confirm which parts of the code should be changed

@dabreegster
Copy link
Collaborator

dabreegster commented Apr 27, 2023

What exactly is the ask here? The output proto is already a letter:

// The Standard Industrial Classification of Economic Activities 2007, 1st

Is businessRegistry.csv changing? If so, then a small amount of code changes internally. See
sic1d2007: u32,
and
/// Turn "A" into 1, "B" into 2, etc

Edit: I didn't read clearly -- so the registry csv is changing. Should be a very easy change in this code

@sgreenbury
Copy link
Collaborator

Initial modifications (9d145dd), yet to be tested on the updated file.

@sgreenbury sgreenbury self-assigned this Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants