-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update model of BMI associated risks #33
Comments
lets define |
So no need for scenario where |
what is currently inside the brackets, which is different every time |
No, you replace the ones we modified the other day because the BMI model was skewed to new values without deleting anything |
@HSalat would you mind take a quick look at this branch, at the moment I got 6 scenarios, including the one with BMI of 50., but also validate if the new equations are correct, so I get the green flag to run all of them. uatk-aspics/aspics/kernels/ramp_ua.cl Line 198 in 82186a8
|
I believe it is, except the BMI > 50 condition is not a scenario. It needs to be there all the time (so at the beginning), this is because the equations can curve down above that value (you might even end up with a negative odd for extreme value), and that part of the model is not supported by the data anyway. PS: I'll check the stuff printed when you run the scenarios, it's the best way to check if it works as intended |
Gotcha, on my way to the run the scenarios, fingers crossed |
The outcomes still don't make sense. Ill keep checking tonight and Mon morning. Here is the latest branch in case you have spare time to double check uatk-aspics/aspics/kernels/ramp_ua.cl Line 198 in 939a676
|
You need to move the BMI > 50 condition before the scenarios, otherwise it gets ignored |
oddBMI
fromto
replacing
[!!! BMI VARIABLE !!!]
accordinglyBMI = 26.7
/if (new_bmi > 26.7)
/if (new_bmi >= 27.7)
else if (new_bmi > 50){ //oddBMI is calculated using 50 for [!!! BMI VARIABLE !!!]}
The text was updated successfully, but these errors were encountered: