Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update model of BMI associated risks #33

Open
HSalat opened this issue Sep 7, 2022 · 9 comments
Open

Update model of BMI associated risks #33

HSalat opened this issue Sep 7, 2022 · 9 comments
Assignees

Comments

@HSalat
Copy link
Collaborator

HSalat commented Sep 7, 2022

  • Change BMI array from 12 parameters to 16, see fitData.csv attached.
  • Update every calculation of oddBMI from
oddBMI = params->bmi_multipliers[originNew * 3] + params->bmi_multipliers[originNew * 3 + 1] * [!!! BMI VARIABLE !!!] + params->bmi_multipliers[originNew * 3 + 2] * pown([!!! BMI VARIABLE !!!],2);

to

oddBMI = params->bmi_multipliers[originNew * 4] + params->bmi_multipliers[originNew * 4 + 1] * [!!! BMI VARIABLE !!!] + params->bmi_multipliers[originNew * 4 + 2] * pown([!!! BMI VARIABLE !!!],2) + params->bmi_multipliers[originNew * 4 + 3] * pown([!!! BMI VARIABLE !!!],3);

replacing [!!! BMI VARIABLE !!!] accordingly

  • update scenarios to BMI = 26.7 / if (new_bmi > 26.7) / if (new_bmi >= 27.7)
  • add else if (new_bmi > 50){ //oddBMI is calculated using 50 for [!!! BMI VARIABLE !!!]}
@mfbenitezp
Copy link
Collaborator

mfbenitezp commented Sep 8, 2022

lets define !!! BMI VARIABLE !!! appropriately., that would be the dynamic new_bmi, am I right?

@mfbenitezp
Copy link
Collaborator

So no need for scenario where new_bmi = 40?, no need for a scenario where else if (new_bmi > 29.0)

@HSalat
Copy link
Collaborator Author

HSalat commented Sep 9, 2022

lets define !!! BMI VARIABLE !!! appropriately., that would be the dynamic new_bmi, am I right?

what is currently inside the brackets, which is different every time

@HSalat
Copy link
Collaborator Author

HSalat commented Sep 9, 2022

So no need for scenario where new_bmi = 40?, no need for a scenario where else if (new_bmi > 29.0)

No, you replace the ones we modified the other day because the BMI model was skewed to new values without deleting anything

@mfbenitezp
Copy link
Collaborator

@HSalat would you mind take a quick look at this branch, at the moment I got 6 scenarios, including the one with BMI of 50., but also validate if the new equations are correct, so I get the green flag to run all of them.

//new_bmi = 26.7; //Scenario 2

@HSalat
Copy link
Collaborator Author

HSalat commented Nov 4, 2022

I believe it is, except the BMI > 50 condition is not a scenario. It needs to be there all the time (so at the beginning), this is because the equations can curve down above that value (you might even end up with a negative odd for extreme value), and that part of the model is not supported by the data anyway.

PS: I'll check the stuff printed when you run the scenarios, it's the best way to check if it works as intended

@mfbenitezp
Copy link
Collaborator

Gotcha, on my way to the run the scenarios, fingers crossed

@mfbenitezp
Copy link
Collaborator

The outcomes still don't make sense. Ill keep checking tonight and Mon morning. Here is the latest branch in case you have spare time to double check

//new_bmi = 26.7; //Scenario 2

@HSalat
Copy link
Collaborator Author

HSalat commented Nov 4, 2022

You need to move the BMI > 50 condition before the scenarios, otherwise it gets ignored

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants